Skip to content

Comments

fix: align sage_attn default hyperparameter return type with refactor#540

Merged
gsprochette merged 1 commit intomainfrom
fix/sage_attn-model-dependant-hyperparameter
Feb 19, 2026
Merged

fix: align sage_attn default hyperparameter return type with refactor#540
gsprochette merged 1 commit intomainfrom
fix/sage_attn-model-dependant-hyperparameter

Conversation

@gsprochette
Copy link
Collaborator

Description

PR #520 changed the return type of get_model_dependent_hyperparameter_default to a dict of {hyperparameter_name: default_value} instead of returning a custom tuple.
This PR applies that change to the sage_attn algorithm.

Related Issue

This could trigger typing errors and cryptic errors with disjoint compatibility down the line.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@gsprochette gsprochette requested a review from simlang February 18, 2026 15:42
@gsprochette gsprochette changed the title fix: allign sage_attn default hyperparameter return type with refactor fix: align sage_attn default hyperparameter return type with refactor Feb 18, 2026
@gsprochette gsprochette merged commit d4b259c into main Feb 19, 2026
7 checks passed
@gsprochette gsprochette deleted the fix/sage_attn-model-dependant-hyperparameter branch February 19, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants